3 ms·
Practically speaking, I think the parts of code review that could actually be covered properly by a checklist could also just be done by software. The parts th
by smackfu 12y ago
Practically speaking, I think the parts of code review that could actually be covered properly by a checklist could also just be done by software. The parts that are "fuzzy" shouldn't really be in a checklist at all.
- MereInterest 12y agoPerhaps having automated tasks be a single check box "Has this task been performed?". For example, instead of having a check for whether braces are in the correct spot, have a check for whether 'astyle' or a similar code formatter has been run.
- joshuacc 12y agoThat can work, but ideally, a CI server would actually run all of those, leaving only a handful of things that require human judgment in the checklist.
- dllthomas 12y agoHow familiar are you with the book? I would recommend reading it, if you haven't. The point of a checklist is to complement expertise. Anything that can be automated should of course be automated and shouldn't be on the checklist. What goes on the checklist are things that humans have to be doing, that are bad when overlooked, and which sometimes get overlooked. It strikes me as likely that, in most situations, there are some such things for code reviews - although what they are may differ from context to context. Trying to find patterns in them would be a fantastic project.