5 ms·
Nobody said it was their responsibility. If adding an optional feature that prevents you from shooting yourself in the foot makes people like github more, mayb
by hamburglar 12y ago
Nobody said it was their responsibility. If adding an optional feature that prevents you from shooting yourself in the foot makes people like github more, maybe it's worth it to them. "Responsibility" has nothing to do with it.
- balls187 12y agoWould have to make it an option, because we check in various AWS keys into private repos. Also how do you differentiate an AWS root key (bad) vs an IAM Key (good)?
- mod 12y agoMaybe you should rethink your policy either way. In my circles, at least, it's standard practice to use environment variables. But I would think clearly it'd be an option.
- balls187 12y ago> Maybe you should rethink your policy either way. Do you have articles discussing the cons of AWS keys in private repos? We deploy our systems on vanilla EC2 instances, which are configured by using a server orchestration system (Ansible). So for any env variables to get set, we'd have to put them in config scripts, which are currently checked into github. To make it clear, we only check in our IAM keys that are AWS service specific, like SES.