3 ms·
Nice work. I read deeper into the changeset and I like. The ->pDataPtr was the one thing behind 90% of the bugs I caused with exts (obviously stuff like the fr
by gopalv 12y ago
Nice work. I read deeper into the changeset and I like.
The ->pDataPtr was the one thing behind 90% of the bugs I caused with exts (obviously stuff like the frozen_array hashtable handling was a completely odd-ball case).
I read deeper and found that you also fixed the "void * *" in zend_hash_find(), which is another pain point in the old API - you cannot rely on the compiler type-checking at all.
I no longer work with PHP, but avenge me for the hair I've lost over the IS_REF madness (copy_ctor vs separate_zval) :)