3 ms·

Goagain by Richard Crowley is a great package that we are using for graceful restarts: https://github.com/rcrowley/goagain https://github.com/rcrowley/goagain

• alexk 12y ago
  I found that it corrupts the FD by using this call: https://github.com/rcrowley/goagain/blob/master/goagain.go#L267 https://github.com/rcrowley/goagain/blob/master/goagain.go#L... Not sure why it happens though, but it led to all sorts of strange intermittent issues with broken connections. Once I replaced this logic with passing files using GetFile().Fd() instead it started working fine, so beware of this. I still wonder why it happens though.
  • fjordan 12y ago
    Thanks for this. Were you able to publish your changes either on a fork or in a PR?
    • alexk 12y ago
      I ended up using different library: https://github.com/gwatts/manners https://github.com/gwatts/manners But the code that extracts the fd without using reflection and access to the private properties is here: https://github.com/mailgun/manners/blob/master/listener.go#L155 https://github.com/mailgun/manners/blob/master/listener.go#L... I think it should be fairly easy to port it to Richard's implementation