5 ms·
Go already has an established contributing process, and people who make PRs without bothering to understand that process are likely just making noise.
by nemothekid 12y ago
Go already has an established contributing process, and people who make PRs without bothering to understand that process are likely just making noise.
- CornishPasty 12y agoIn that case why are they using GitHub?
- nemothekid 12y agoLinux is on Github as well (https://github.com/torvalds/linux https://github.com/torvalds/linux) , and probably like Linus, some people don't like the Pull-request method for dealing with contributions.
- sfk 12y agoLinux is on https://git.kernel.org/cgit/ https://git.kernel.org/cgit/ .
- sfk 12y agoInteresting that the git hipsters are downvoting factually correct information. "Unruly hackers" (pg) seem to be perfect fodder for groupthink and monopolies.
- nemothekid 12y agoAnd go is technically on https://go.googlesource.com/go https://go.googlesource.com/go
- dsymonds 12y agoGitHub is only a mirror. The real work is happening on go.googlesource.com. https://groups.google.com/d/topic/golang-dev/sckirqOWepg/discussion https://groups.google.com/d/topic/golang-dev/sckirqOWepg/dis...
- vertex-four 12y agoGitHub provides the best web-based git repository browser, as well as various other useful features. The only other reasonable alternative for a large open-source project, aside from self-hosting, is bitbucket.
- rplnt 12y agoI would like to disagree with the "the best". Mostly because it's obviously your opinion and not something you can say definitely.
- tomp 12y agoCan you give any alternatives?
- rplnt 12y agoWell the already mentioned bitbucket, stash, cgit, gitweb, ... My point is that if you like something it isn't automatically "the best".
- coldtea 12y agoSometimes you have to learn to trust your opinion too -- and to learn to access others opinions when there are no definite answers.
- 1wd 12y agoCould you describe what makes it the best repository browser? I like e.g. https://trac.openstreetmap.org/browser/chef https://trac.openstreetmap.org/browser/chef
- sfk 12y agoI disagree. GitHub looks cluttered and the contrast is too low for speed reading. I prefer the hg interface, for example: https://hg.python.org/cpython/ https://hg.python.org/cpython/ Another interface I prefer is: http://cvsweb.openbsd.org/cgi-bin/cvsweb/ http://cvsweb.openbsd.org/cgi-bin/cvsweb/
- farresito 12y agoSo that they have the wiki+issues stuff.
- ishityounot 12y agoIs their contributing process described in README or in some other file within the repo?
- enneff 12y agoThere is, but since we're only partway through migrating to git/github, the README still shows the old instructions. The new contribution instructions will appear here in the next few days: http://golang.org/doc/contribute.html http://golang.org/doc/contribute.html Not that it really matters, right now, as we're in a pre-release freeze.
- rurounijones 12y agoMake sure there is a CONTRIBUTING.md file in the repo and Github will automatically highlight it to be read when someone opens a PR
- enneff 12y agoGreat suggestion, thank you!