4 ms·

It's unfortunate that it isn't possible to disable pull requests. There is already noise appearing there, which will always be a wart so long as pull requests c

It's unfortunate that it isn't possible to disable pull requests. There is already noise appearing there, which will always be a wart so long as pull requests can't be disabled.

ishityounot 12y ago
Noise? That's how contributions are called now?
- colinramsay 12y ago
  No, it's just that the Go team have decided to continue with their current contribution process rather than using pull requests. I don't know whether this is a permanent decision or not. "The Go team will not be accepting pull-requests here. Contributions must still go through the normal code-review process and gerrit. The updated contribution steps are not yet available though." https://github.com/golang/go/pull/9219 https://github.com/golang/go/pull/9219
  - tachion 12y ago
    This is something very similar to that is being planned for FreeBSD repositories on GitHub: automated process turning pull requests into FreeBSD's Bugzilla bug reports and a comment closing the pull request, informing user about the Bugzilla bug link and how to proceed.
    - colinramsay 12y ago
      Actually that's even better than disabling pull requests entirely. I guess the closing comment will also contain a link to contribution guidelines and such. Edit: @rurounijones points out that if there's a CONTRIBUTING.md in the repo then Github will show it when someone creates a PR. That's a great feature!
- iand 12y ago
  Yes, when they are on a mirror of a code repo. The upstream repo is at https://go.googlesource.com/go https://go.googlesource.com/go
- nemothekid 12y ago
  Go already has an established contributing process, and people who make PRs without bothering to understand that process are likely just making noise.
  - CornishPasty 12y ago
    In that case why are they using GitHub?
    - nemothekid 12y ago
      Linux is on Github as well (https://github.com/torvalds/linux https://github.com/torvalds/linux) , and probably like Linus, some people don't like the Pull-request method for dealing with contributions.
      - sfk 12y ago
        Linux is on https://git.kernel.org/cgit/ https://git.kernel.org/cgit/ .
        sfk 12y ago
        Interesting that the git hipsters are downvoting factually correct information. "Unruly hackers" (pg) seem to be perfect fodder for groupthink and monopolies.
        nemothekid 12y ago
        And go is technically on https://go.googlesource.com/go https://go.googlesource.com/go
    - dsymonds 12y ago
      GitHub is only a mirror. The real work is happening on go.googlesource.com. https://groups.google.com/d/topic/golang-dev/sckirqOWepg/discussion https://groups.google.com/d/topic/golang-dev/sckirqOWepg/dis...
    - vertex-four 12y ago
- masklinn 12y ago
  Github PRs are noise when the contribution workflow does not use PRs. Go's contribution workflow does not use PRs.
ivank 12y ago
I've seen projects solve this problem by keeping a pull request open that indicates where contributions should go instead.
- jbrooksuk 12y ago
  That still doesn't prevent people blindly creating a new pull request though.
deleted 12y ago
[deleted]

It's unfortunate that it isn't possible to disable pull requests. There is already noise appearing there, which will always be a wart so long as pull requests can't be disabled.

ishityounot 12y ago

Noise? That's how contributions are called now?

colinramsay 12y ago
No, it's just that the Go team have decided to continue with their current contribution process rather than using pull requests. I don't know whether this is a permanent decision or not. "The Go team will not be accepting pull-requests here. Contributions must still go through the normal code-review process and gerrit. The updated contribution steps are not yet available though." https://github.com/golang/go/pull/9219 https://github.com/golang/go/pull/9219
- tachion 12y ago
  This is something very similar to that is being planned for FreeBSD repositories on GitHub: automated process turning pull requests into FreeBSD's Bugzilla bug reports and a comment closing the pull request, informing user about the Bugzilla bug link and how to proceed.
  - colinramsay 12y ago
    Actually that's even better than disabling pull requests entirely. I guess the closing comment will also contain a link to contribution guidelines and such. Edit: @rurounijones points out that if there's a CONTRIBUTING.md in the repo then Github will show it when someone creates a PR. That's a great feature!
iand 12y ago
Yes, when they are on a mirror of a code repo. The upstream repo is at https://go.googlesource.com/go https://go.googlesource.com/go
nemothekid 12y ago
Go already has an established contributing process, and people who make PRs without bothering to understand that process are likely just making noise.
- CornishPasty 12y ago
  In that case why are they using GitHub?
  - nemothekid 12y ago
    Linux is on Github as well (https://github.com/torvalds/linux https://github.com/torvalds/linux) , and probably like Linus, some people don't like the Pull-request method for dealing with contributions.
    - sfk 12y ago
      Linux is on https://git.kernel.org/cgit/ https://git.kernel.org/cgit/ .
      - sfk 12y ago
        Interesting that the git hipsters are downvoting factually correct information. "Unruly hackers" (pg) seem to be perfect fodder for groupthink and monopolies.
      - nemothekid 12y ago
        And go is technically on https://go.googlesource.com/go https://go.googlesource.com/go
  - dsymonds 12y ago
    GitHub is only a mirror. The real work is happening on go.googlesource.com. https://groups.google.com/d/topic/golang-dev/sckirqOWepg/discussion https://groups.google.com/d/topic/golang-dev/sckirqOWepg/dis...
  - vertex-four 12y ago
masklinn 12y ago
Github PRs are noise when the contribution workflow does not use PRs. Go's contribution workflow does not use PRs.

ivank 12y ago

I've seen projects solve this problem by keeping a pull request open that indicates where contributions should go instead.

jbrooksuk 12y ago
That still doesn't prevent people blindly creating a new pull request though.

deleted 12y ago

[deleted]