5 ms·

I'm in a similar situation: https://github.com/JuliaLang/julia/pull/7714 https://github.com/JuliaLang/julia/pull/7714 Can someone help me what would be the pol

by jhasse 12y ago

I'm in a similar situation: https://github.com/JuliaLang/julia/pull/7714 https://github.com/JuliaLang/julia/pull/7714 Can someone help me what would be the polite way to do? I really don't want to annoy anyone, but also wouldn't want my work to be only on my local branch ;)

glesica 12y ago
Have you tried posting to the dev mailing list? You might also check out the IRC channel (#julia on Freenode).
StefanKarpinski 12y ago
Bumping the issue by posting something is probably the best way to go. I promise we won't get annoyed and it's easy to miss things like this. I suspect that what happened here is that all of the people who commented didn't feel like they had the "authority" to just go ahead an merge it, while everyone else (myself included) wasn't following the conversation (July was a really busy month) and didn't feel informed enough to pull the trigger. From a quick scan just now, this conversation looked to me like there were unresolved issues still, but upon more careful reading, that's not the case. It can be helpful to say something like: "I believe all the issues people have raised have been addressed. This should now be good to go." This change is quite nice and I'm testing it out right now. Sorry this languished for so long and I hope it won't discourage you from contributing – it is very much appreciated. Update: this is now merged into Julia master. Thank you!
- jhasse 12y ago
  Cool! Thanks :) I guess Hacker News rocks and also Dan Luu is right about "Props to OpenBlas, Julia, Rust, jslinux-deobfuscated, and np for being incredibly friendly to new contributors."
- ViralBShah 12y ago
  I think we should separate out some developer documentation from the main documentation and put this there. This is a common question on a new contributor's mind, and having something like this written up in our developer documentation will probably go a long way towards putting them at ease. The number of open PRs is now large enough, that it is not possible for any one person to chase them, and things occasionally do slip by.

by jhasse 12y ago

glesica 12y ago

Have you tried posting to the dev mailing list? You might also check out the IRC channel (#julia on Freenode).

StefanKarpinski 12y ago

Bumping the issue by posting something is probably the best way to go. I promise we won't get annoyed and it's easy to miss things like this. I suspect that what happened here is that all of the people who commented didn't feel like they had the "authority" to just go ahead an merge it, while everyone else (myself included) wasn't following the conversation (July was a really busy month) and didn't feel informed enough to pull the trigger. From a quick scan just now, this conversation looked to me like there were unresolved issues still, but upon more careful reading, that's not the case. It can be helpful to say something like: "I believe all the issues people have raised have been addressed. This should now be good to go." This change is quite nice and I'm testing it out right now. Sorry this languished for so long and I hope it won't discourage you from contributing – it is very much appreciated. Update: this is now merged into Julia master. Thank you!

jhasse 12y ago
Cool! Thanks :) I guess Hacker News rocks and also Dan Luu is right about "Props to OpenBlas, Julia, Rust, jslinux-deobfuscated, and np for being incredibly friendly to new contributors."
ViralBShah 12y ago
I think we should separate out some developer documentation from the main documentation and put this there. This is a common question on a new contributor's mind, and having something like this written up in our developer documentation will probably go a long way towards putting them at ease. The number of open PRs is now large enough, that it is not possible for any one person to chase them, and things occasionally do slip by.