3 ms·
Is git/mercurial poor version control in your opinion? OP demonstrates exactly why. imagine a block with 25 variable assignments. All variable with 3 letters no
by nsfyn55 12y ago
Is git/mercurial poor version control in your opinion? OP demonstrates exactly why. imagine a block with 25 variable assignments. All variable with 3 letters now you add a variable with 4 letters. You have to edit the 25 preceding lines with a space to accommodate the new letter. Now all diffs from here to eternity spew this out.
Not to mention you've now greatly increased the surface area for merge conflicts. I mean what if someone else added a 5 letter variable?
- cma 12y agoYou can tell the diff to ignore spacing with an option. It still ends up messing up stuff like git-blame and other stuff and isn't always worth it.
- nsfyn55 12y agoI don't believe this will save you from the merge conflicts.
- luckydude 12y agoIt won't. Source: does version control for a living. The big problem with OP's point of view, IMO, is that you change the authorship of the lines when you line things up like that. If it is done from day 1, fine. Otherwise leave other people's code alone. Why? Because unless you are using a system that makes blame slow (I'm looking at you, git), blame your goto helper for understanding the code's evolution. Our blame is essentially instant and I use it to debug problem reports while I'm on the phone with the customer all the time. I'm all for good style guides and obeying them. But rewriting other people's code for you shiny new style hides a lot of useful history.