4 ms·
Took a brief look at the front page. - No side-by-side diffs? Didn't see any in screen shots. - The scopes asked for seem very broad. I may be confused, but i
by skj 12y ago
Took a brief look at the front page.
- No side-by-side diffs? Didn't see any in screen shots.
- The scopes asked for seem very broad. I may be confused, but it seemed like it was asking for write access to all repositories, public and private. I have access to several private repos (but I don't own them) for which this is unacceptable. If the scope is limited to the ones under github.com/me then it's not as big a deal... In any case, the scary scope list prevented me from experimenting.
- Spitfire777 12y agoHi skj! - What do you exactly mean by side-by-side diff? Currently you have diff view between the current HEAD of the Pull Request branch by the base commit. - Yes, that is true. This is a known issue mentioned by others and there is definitely a need to fix that. ReviewNinja comes from the GitHub Enterprise context, where you usually can trust the internal tool offering, that's why we kept it simple with the permissions in the first place. Thank you for the feedback!
- skj 12y agoHere's a screenshot of some side-by-side diff action: https://fr.atlassian.com/wac/software/fisheye/overview/screenshot-tour/featureItems/0/featureItems/0/imageBinary/fisheye-side-by-side-diff.png https://fr.atlassian.com/wac/software/fisheye/overview/scree... Basically, it let's you look at the old code, or look at the new code, or see how they're different, all at the same time. Inline diffs (github-style) require you to keep a context as you scan through code, and it makes it harder to keep everything in your head.