4 ms·
Go team member here. I've used five different code review tools, and Github is the worst of the five. I regularly bug them (Github) about this, and they know i
by bradfitz 12y ago
Go team member here.
I've used five different code review tools, and Github is the worst of the five. I regularly bug them (Github) about this, and they know it. I hear rumors they've been working on it a lot.
Github's review mechanisms barely scratch the surface of what's possible.
- Locke1689 12y agoIf any of the other ones are public, which did you like best? IIRC, Mondrian was good, but not great.
- bradfitz 12y agoFrom best to worse, in my experience: 1) Google's current internal one 2) Gerrit (open source, to be used by Go) 3) Google's old one (Mondrian) 4) Rietveld (open source, but run for free at codereview.appspot.com) 5) Github I would totally suspect that Phabricator or Review Board would be well above Github (as are 1-4 in my list), but I don't know where. I have little desire to use or explore new code review systems at this point. Four per day is enough for me at the moment.
- piotrkaminski 12y agoIn case you do want to try out another one at some point, I built https://reviewable.io https://reviewable.io to take some of my favorite features from Google's internal tool but integrate seamlessly with GitHub.
- maherbeg 12y agoReview Board isn't as good as it could be. Sometimes it's diffing tool provides far too much noise to be useful.
- zippergz 12y agoMondrian is the best code review tool I've ever used, but I'll admit that could be damning with faint praise... I'm very curious to hear what the better options are, because we use Github at my current company and I would go back to Mondrian in a heartbeat.
- chenglou 12y agoHave you ever, by coincidence, used Phabricator? If so, what's your opinion of it? I've used Phabricator full-time for a while and it's been really a joy.