3 ms·
I loves these sorts of robots because I hate being "that guy" who nitpicks over things like trailing white space. (It matters!!) There's really no way not to s
by colinbartlett 12y ago
I loves these sorts of robots because I hate being "that guy" who nitpicks over things like trailing white space. (It matters!!)
There's really no way not to sound like a pedantic jerk when you comment on someone's pull request about such things.
This at least makes the robot out to be the pedant.
- tessierashpool 12y agothe other thing to do is just go through the code base later, fixing those kinds of things. i.e., let it go on the pull request, but go through all the code and fix every instance once a month or something. a few years ago, IIRC, Josh Peek did that for the Rails code base and that one commit got like five thousand "thank you" comments.
- ryanto 12y agoA problem with this is it adds useless commit history. If I make a significant change to some code, but then later on you remove some bad formatting/white spaces the latest commit messages for that code block is most likely "removed whitespace" and not something more meaningful. That, and tasks that are left to be dealt with later are tasks that never get done.
- icedchai 12y ago99% of the time it actually doesn't matter, so don't comment on it.
- logicalman 12y agoStyle guide violations can introduce bugs when moving from one system to another. At best, they slow down communication when someone can't easily understand your code.
- icedchai 12y agoAre you telling me someone can't understand my code because I left two spaces at the end of the line? Then they should be fired.