3 ms·
We do team based pull request reviews. (in github) You need two other seniors to give you +1 to move on. The number "two" comes from the fact that we are still
by andreasklinger 12y ago
We do team based pull request reviews. (in github)
You need two other seniors to give you +1 to move on.
The number "two" comes from the fact that we are still a small team.
People can will still review stuff that has already two +1's but the commiter could already move on if needed.
The advantage of pull requests is less "teaching how to do it properly" but more "learning from each other" and "continous exposure to all parts of the codebase".
Thus it's not the job of the Team Lead to do this reviews but everyone's.
Pull requests reviews are done (asynchronously) done each morning (whatever this means for each person/timezone). This leads to the fact that you usually can expect PRs to be done within 12-36hours.
I could not imagine working in a team with different experience levels (not speaking of countries/timezones/specialisation) without pull request reviews.
- cscharenberg 12y agoThis is a good process and works well for my company as well. Everyone does code reviews but you need 2 senior people to call it complete and check it in. The other part is encouraging them to be engineers, not "coders". Coding implies write code and shoot it out. Engineering is a mindset of continuous improvement and complete examination of the problem and solution.