3 ms·
I wrote a short blog post for work about this http://blog.cloudflare.com/making-code-better-with-reviews/ http://blog.cloudflare.com/making-code-better-with-rev
by jgrahamc 12y ago
I wrote a short blog post for work about this http://blog.cloudflare.com/making-code-better-with-reviews/ http://blog.cloudflare.com/making-code-better-with-reviews/
Simply put: we use git and developers can't commit to the master branch. They commit to their own branch, the build system builds/tests that branch and the developer makes a pull request and gets the code reviewed.
- kevincennis 12y agoI enthusiastically second the suggestion to use pull requests. They make a huge difference in my experience, for a few reasons: 1) You're more likely to catch bugs, security issues, and potential performance problems before they get into your main branch. 2) Your developers will get feedback on their code, which is hugely important to growth (you can't learn from your mistakes if you don't know you're making them). 3) Your developers will learn how to give feedback, and how to have constructive discussions about code by virtue of reviewing and commenting on pull requests. 4) I think there's some light, healthy social pressure when you know that other people are going to be doing code reviews. People seem to be a bit less likely to take the "easy" (read "hacky") way out of a problem when they know there will be eyes on their code. My experience has been that most developers really like getting feedback and having these discussions. And I've definitely seen them pay off.