3 ms·
The LOG.debug commands are executed when the singleton is used, but not when it is created. I think it should be the opposite. The create method called from ge
by reacweb 12y ago
The LOG.debug commands are executed when the singleton is used, but not when it is created. I think it should be the opposite.
The create method called from getInstance should probably be private.
It is called without parameter in getInstance, but has a mandatory String parameter. This seems inconsistant.
The presence of two return instructions is also against many guidelines.
There is an accumulation of too many issues for such a classical pattern.