3 ms·

I suspect nobody playing with the USB code would have to look up the type of bNumEndpoints. The `b' prefix tells you it's a byte (this is a common thing in the

by to3m 12y ago

I suspect nobody playing with the USB code would have to look up the type of bNumEndpoints. The `b' prefix tells you it's a byte (this is a common thing in the USB spec), and you'll probably know it's a byte anyway due to familiarity... Another way of looking at the matter is that you shouldn't change code that's already correct.

dezgeg 12y ago
> I suspect nobody playing with the USB code would have to look up the type of bNumEndpoints. I could very well imagine a security auditor (who is not an USB expert) reading this code. > Another way of looking at the matter is that you shouldn't change code that's already correct. I personally find this kind of attitude extremely worrying. Perceptions about what is bad/good code or secure/insecure code have definitely changed since the first days of Unix. We shouldn't let code slip through the cracks just because it's old.