4 ms·
https://github.com/thebradbain/snapception/blob/master/snapception/decrypt_snap.rb#L17 https://github.com/thebradbain/snapception/blob/master/snapc... Oh lordy
by philangist 12y ago
https://github.com/thebradbain/snapception/blob/master/snapception/decrypt_snap.rb#L17 https://github.com/thebradbain/snapception/blob/master/snapc...
Oh lordy. I wonder if they eval() arbitrary input from users as well.
- thebradbain 12y agoDeveloper here — I think I recognized I had written some hastily written code in the bottom of my repo. Please, feel free to submit a pull request.
- philangist 12y agoI think maybe I should've been more clear. I was referring to Snapchat's horrible security policies in that comment, it was not a criticism of your code.
- thebradbain 12y agoDon't worry about it. I made a system call using process.call() and thought maybe that's what you were referring to.
- nkozyra 12y agoWhat other bad practices should we be looking for ;)
- spacemanmatt 12y agoStandard disclaimer applies: Code is dangerous, yo. ;)