3 ms·
Quite a few bad practices. 1. Separate python 2 and python 3 modules? How can I be sure that they both do the same thing? 2. You have the tarball in your sour
by ayrx 12y ago
Quite a few bad practices.
1. Separate python 2 and python 3 modules? How can I be sure that they both do the same thing?
2. You have the tarball in your source control. Why?
3. You have a 1.7k line file. Something tells me that they can be split up into smaller modules.
4. Commented out code? Why is it in there? If it's unused, remove it.
5. No lines between methods, single line between classes. Please have a look at PEP8.
6. You have that .pysparse file in source control. Why?
7. You say that Pyvok depends on Scipy and Numpy but you don't specify the dependency in your setup.py file. Anyone that installs the package from PyPI is going to have a broken package.
- ricsca 12y agoAll good points, thanks for pointing them out. I'll consider each one carefully.