4 ms·

This is cool! Around line 327, would it be better to use classSet rather than string concatenation? http://facebook.github.io/react/docs/class-name-manipulati

This is cool! Around line 327, would it be better to use classSet rather than string concatenation? http://facebook.github.io/react/docs/class-name-manipulation.html http://facebook.github.io/react/docs/class-name-manipulation...

baddox 12y ago
It certainly would. I wish React would improve the syntax by allowing the className prop to directly take an object.
- peterhunt 12y ago
  Hehe, believe it or not pre-open source react supported this. We thought it was too magical but it was crazy convenient.
  - baddox 12y ago
    I'm generally a fan of explicitness, but it's just such a ubiquitous pattern that I think the convenience would make it worth it.
henleyedition 12y ago
Haha, awesome. As I was writing it I was like, well this is stupid. Thanks for the link!