5 ms·
The first question it asked me was: int SSL_shutdown(SSL *s) { if (s->handshake_func == 0) { SSLerr(SSL_F_SSL_SHUTDOWN, SSL_R_UNINITIALIZED);
by milliams 12y ago
The first question it asked me was:
int SSL_shutdown(SSL *s)
{
if (s->handshake_func == 0)
{
SSLerr(SSL_F_SSL_SHUTDOWN, SSL_R_UNINITIALIZED);
return -1;
}
if ((s != NULL) && !SSL_in_init(s))
return(s->method->ssl_shutdown(s));
else
return(1);
}
....
}
so of course the first thing I noticed was the mismatched braces after the 'else'. The 'intended' error was elsewhere (and I agree with it) but to say that the brace isn't an error is a bit much given the sorts of problems that PVS is normally finding.
- rikkus 12y agoYes there's a typo / mispaste in the code there, but of course that wouldn't compile and they're not asking what wouldn't compile ('....' wouldn't compile either).
- shmerl 12y agoIt's hard to say about that, since there is ... which can contain anything (like for example another opening { ). It's a good practice to always use braces with if / else even if it's just one line in them.
- _RPM 12y agoI don't think you are right. Regardless if what is after that contained in the `...` wouldn't matter. A lone `{` or `}` would be a syntax error.
- shmerl 12y agoAs I said, it wouldn't be a syntax error if ... contained the matching { somewhere inside. That lone } which seemingly belongs to if in this case would be closing the function.