3 ms·
I'm one of the authors of react router. How do you feel about <script/> tags, or <link/> or <meta/> or <base/>?
by ryanflorence 12y ago
I'm one of the authors of react router.
How do you feel about <script/> tags, or <link/> or <meta/> or <base/>?
- skrebbel 12y agoLike something we're forced to use, but in all honesty I don't completely see where you're getting at. Note, I now regret singling out react-router. I'm still learning that on places like HN, it's best to avoid giving examples when discussing software design in abstract terms, because you're needlessly singling out some good people (in this case, you), plus half the discussion becomes a nitpick about the example instead of a discussion about design principles. I do actually believe that react-router is a bad fit for JSX, let alone React components, but I also think that others are allowed to disagree. The best I can do is try and encourage careful thought when considering JSX, which is what I wrote my comment for, but if people disagree with me on exactly where to draw the line, then that's not really a problem is it? I hardly have any open source to show for, so you're already way ahead of me, and in the few things I do have on Github, I bet that you'd disagree with some design decisions I made as well. Sorry for dragging you into this. Open source is unrewarding work and I surely didn't help.