3 ms·
While this is a very welcomed change, i feel the split diff view could do a much better job on some cases. For instance, this is how GitHub renders a commit th
by epidemian 12y ago
While this is a very welcomed change, i feel the split diff view could do a much better job on some cases.
For instance, this is how GitHub renders a commit that adds a wrapper HTML element (and indents all its contents) and changes a class name: http://i.imgur.com/4Lcozgz.png http://i.imgur.com/4Lcozgz.png. Not so good. Contrast that with how IDEA renders the same diff: http://i.imgur.com/RGf8psr.png http://i.imgur.com/RGf8psr.png. It makes it obvious where the wrapper tags where added, and which class name changed (which is completely lost within the green glob of the GH diff).
Now, the whitespace-agnostic view on GH (adding ?w=0 to the diff URL) is much better: http://i.imgur.com/AKNn1fW.png http://i.imgur.com/AKNn1fW.png. It looks very similar to the IDEA version: http://i.imgur.com/NpDsYBB.png http://i.imgur.com/NpDsYBB.png. I wish GH remembered the ?w=0 preference just as it remembers to use the split diff.
- mdo 12y ago> I wish GH remembered the ?w=0 preference just as it remembers to use the split diff. Me too! I'm working on that, but it's a bit tough as it changes the order of the lines that are rendered in the browser. Thus, code comments would kind of be borked. Bottom line, lots to rewrite before we can do just that, but we are 100% aware of it.