3 ms·

I almost sent an email at work in all caps rejoicing this. Redid the casing, then sent it. Very pleased to see this. I had implemented my own git fetch pr -> e

by codemac 12y ago

I almost sent an email at work in all caps rejoicing this. Redid the casing, then sent it. Very pleased to see this. I had implemented my own git fetch pr -> emacs ediff -> commints in org file -> add comments to github flow due to how horrible the unified view was for long/large code reviews. If they can unfuck the "so-and-so has commented on an old commit" thing hiding valuable conversation, we start to get into a real code review tool.

mdo 12y ago
> If they can unfuck the "so-and-so has commented on an old commit" thing hiding valuable conversation, we start to get into a real code review tool. We'll get there ;).
- mackwic 12y ago
  So, you work at github now ? That explains a lot about the new bits of UI we found here and there everyday. What are you planning to do next ? Can't wait to get there.
  - mdo 12y ago
    Hah, been here for nearly two years now :). And no spoilers!
lord_quas 12y ago
You could just use magit, right?
- codemac 12y ago
  I started implementing some of it into magit, but I could never get magit + ediff working in a way I liked more than just invoking ediff myself. Knowing the thorougness of magit, there's probably a way to successfully do this with minimal customization.