3 ms·
This looks nice, but I do have some quibbles of a different nature. https://github.com/Ehesp/Responsive-Dashboard/blob/master/js/angular/bootstrap.js#L59 https
by Bahamut 12y ago
This looks nice, but I do have some quibbles of a different nature.
https://github.com/Ehesp/Responsive-Dashboard/blob/master/js/angular/bootstrap.js#L59 https://github.com/Ehesp/Responsive-Dashboard/blob/master/js... - this is an expensive operation. It would be better to use window.matchMedia and do a $scope.$apply() only precisely when needed. https://github.com/Ehesp/Responsive-Dashboard/blob/master/js/angular/bootstrap.js#L25 https://github.com/Ehesp/Responsive-Dashboard/blob/master/js... is also expensive too, since getWidth is a function.
My other criticism is that it should avoid adding ngCookies as a requirement, as it is a not so great portion of angular.
I think some of the people criticizing this miss the point of something like this. It is a theme that is geared specifically towards people who use Angular & don't want to use jQuery. If you don't use Angular/want to use Angular, this isn't for you - or you can fork it and port it over.
- aliasell 12y agoHey, thanks for the suggestions appreciated. I'll dig into the width and apply areas, my JS isn't my strongest area so the implementation came from a "what works" situation.
- deleted 12y ago[deleted]