3 ms·
Is there a reasonable use case for linking to line-numbers on branch/tag on github? If not, it might be good UX to remove that option. i.e. only honour such lin
by jbert 12y ago
Is there a reasonable use case for linking to line-numbers on branch/tag on github? If not, it might be good UX to remove that option. i.e. only honour such links to immutable urls.
Further, even if you're looking at a mutable reference (like master), the line number links could/should be to the underlying immutable url (based on the commit).
If there is a marginal use case for linking to line numbers of mutable refs, perhaps it should be the non-default case, discoverable by keyboard shortcut like this...
- mtdewcmu 12y agoLinking to line numbers is practically using goto, which is a coding faux pas. I'm sure they must be on the way out.
- warp 12y agoYes, in a team working remotely it is often useful to link to a specific chunk of code during a (voice or chat) conversation. Typically you're talking about the current code in a branch, and it is useful for the person clicking the link to know that we are in fact talking about HEAD and not a specific commit. This is the equivalent of calling someone to your desk and pointing at the screen. It is fine if those links stop working a few hours later.
- jbert 12y agoI think that also works if the link is actually to the immutable commit to which the branch is currently pointing?
- augustl 12y agoGood point, it would make sense to disable the feature for mutable references like "master".