4 ms·
"51 files changed, 1809 insertions(+), 633 deletions(-)." - am i missing something, or is amount of code changed a good thing? Like was there a lot of bad code
by therobot24 12y ago
"51 files changed, 1809 insertions(+), 633 deletions(-)." - am i missing something, or is amount of code changed a good thing? Like was there a lot of bad code, and now it's changed to be good...or is this just a measure of improvement like "look at how much work we did". I dunno, i'm out of the loop on this stuff i guess.
- shazow 12y agoAll code metrics are vanity metrics, but they're fun to look at. If you want a deep sense of what was changed, take a look at https://github.com/shazow/urllib3/blob/master/CHANGES.rst https://github.com/shazow/urllib3/blob/master/CHANGES.rst and the individual issues referenced. Edit: In this particular case, it's simply the output of `git diff --stat`
- coldtea 12y ago>am i missing something, or is amount of code changed a good thing? Like was there a lot of bad code, and now it's changed to be good... That's the idea when you're doing a rewrite, especially after years of experience with the pain points, and wanting to address specific issues/bugs. That the old code was bad, and you add new code that fixes some stuf. It might not be perfect, but then nothing is.
- pbreit 12y agoI think you're trying too hard to find badness. It's just a simple few data points of what the author was able to achieve in the two week sprint. It's reasonable to assume it was predominantly improvements.
- therobot24 12y agonot really trying, saw it and didn't get it - figured the forum would have answers, downvotes seem to disagree, but whatever