4 ms·

Some discussion about this method at http://derickrethans.nl/immutable-datetime.html http://derickrethans.nl/immutable-datetime.html

by mherdeg 12y ago

nkozyra 12y ago
That seems to explain the logic of having an immutable DateTime type (to avoid breaking backwards compatibility with the inherently mutable old DateTime) but doesn't explain the logic of then including a modify() method for such objects. "Immutable" probably isn't the right description.
- arankine 12y ago
  The method returns a new instance, so it is still immutable, technically.
  - nkozyra 12y ago
    Then the whole thing is redundant. If clone $var = DateTimeImmutable->modify() Then this really doesn't solve anything.
    - pilif 12y ago
      Let's compare the old thing: $date = new DateTime(); $other_date = $date->modify('+ 1 day'); // $date is now tomorrow with the new thing: $date = new DateTimeImmutable(); $other_date = $date->modify('+ 1 day'); // $date is still today Then, yes, clone($date_time)->modify() is equivalent to calling modify() on a $date_time, but the problem starts when you pass DateTime instances into functions because you just can't know what the function is going to do to that date object. This means that you have to be very defensive, constantly calling clone() or you'll have your dates altered behind your back from some library that's called by a library you're calling.
- pilif 12y ago
  objects of the DateTimeImmutable class are immutable. All methods that modify the object will return a new copy. While the naming is a bit unfortunate, this isn't different from other languages that have immutable types like Java String which also have methods that act on the string they are called on and return a new copy. Like concat(). String foo = "foo"; String foobar = foo.concat("bar"); // foo is still set to "foo" And with datetimeimmutable: $date = new DateTimeImmutable(); $other_date = $date->modify('+ 3 days'); // $date still is today. Python strings work the same. And all the ruby string methods not ending with a bang also work the same. The reason why the method is called 'modify' in PHP is because the old DateTime (mutable edition™) method was also called 'modify' and the two should be more or less drop-in replacements. Besides - what would you call a method that modifies a timestamp?
  - diego 12y ago
    $date->modifiedDate('+ 3 days');
  - masklinn 12y ago
    > The reason why the method is called 'modify' in PHP is because the old DateTime (mutable edition™) method was also called 'modify' and the two should be more or less drop-in replacements. The old datetime's method modifies the object in place[-1], if you replace the old with the new it's not going to work anymore. > Besides - what would you call a method that modifies a timestamp? Replace[0]? withFieldValue[1]? add with a delta object, possibly relative[2]? [-1] it also returns the object it was called on since 5.3.0, the method was introduced in 5.2.0 [0] https://docs.python.org/2/library/datetime.html#datetime.datetime.replace https://docs.python.org/2/library/datetime.html#datetime.dat... [1] http://joda-time.sourceforge.net/apidocs/org/joda/time/DateTime.html#withCenturyOfEra(int) http://joda-time.sourceforge.net/apidocs/org/joda/time/DateT... [2] http://msdn.microsoft.com/en-us/library/system.datetime.add(v=vs.110).aspx http://msdn.microsoft.com/en-us/library/system.datetime.add(...
    - shawnz 12y ago
      > The old datetime's method modifies the object in place[-1], if you replace the old with the new it's not going to work anymore. Of course it would be impossible to make the APIs exactly the same, because the two classes have different behaviour. But shouldn't they at least strive to make the APIs as similar as possible?

Some discussion about this method at http://derickrethans.nl/immutable-datetime.html http://derickrethans.nl/immutable-datetime.html

by mherdeg 12y ago

Some discussion about this method at http://derickrethans.nl/immutable-datetime.html http://derickrethans.nl/immutable-datetime.html

nkozyra 12y ago

That seems to explain the logic of having an immutable DateTime type (to avoid breaking backwards compatibility with the inherently mutable old DateTime) but doesn't explain the logic of then including a modify() method for such objects. "Immutable" probably isn't the right description.

arankine 12y ago
The method returns a new instance, so it is still immutable, technically.
- nkozyra 12y ago
  Then the whole thing is redundant. If clone $var = DateTimeImmutable->modify() Then this really doesn't solve anything.
  - pilif 12y ago
    Let's compare the old thing: $date = new DateTime(); $other_date = $date->modify('+ 1 day'); // $date is now tomorrow with the new thing: $date = new DateTimeImmutable(); $other_date = $date->modify('+ 1 day'); // $date is still today Then, yes, clone($date_time)->modify() is equivalent to calling modify() on a $date_time, but the problem starts when you pass DateTime instances into functions because you just can't know what the function is going to do to that date object. This means that you have to be very defensive, constantly calling clone() or you'll have your dates altered behind your back from some library that's called by a library you're calling.
pilif 12y ago
objects of the DateTimeImmutable class are immutable. All methods that modify the object will return a new copy. While the naming is a bit unfortunate, this isn't different from other languages that have immutable types like Java String which also have methods that act on the string they are called on and return a new copy. Like concat(). String foo = "foo"; String foobar = foo.concat("bar"); // foo is still set to "foo" And with datetimeimmutable: $date = new DateTimeImmutable(); $other_date = $date->modify('+ 3 days'); // $date still is today. Python strings work the same. And all the ruby string methods not ending with a bang also work the same. The reason why the method is called 'modify' in PHP is because the old DateTime (mutable edition™) method was also called 'modify' and the two should be more or less drop-in replacements. Besides - what would you call a method that modifies a timestamp?
- diego 12y ago
  $date->modifiedDate('+ 3 days');
- masklinn 12y ago
  > The reason why the method is called 'modify' in PHP is because the old DateTime (mutable edition™) method was also called 'modify' and the two should be more or less drop-in replacements. The old datetime's method modifies the object in place[-1], if you replace the old with the new it's not going to work anymore. > Besides - what would you call a method that modifies a timestamp? Replace[0]? withFieldValue[1]? add with a delta object, possibly relative[2]? [-1] it also returns the object it was called on since 5.3.0, the method was introduced in 5.2.0 [0] https://docs.python.org/2/library/datetime.html#datetime.datetime.replace https://docs.python.org/2/library/datetime.html#datetime.dat... [1] http://joda-time.sourceforge.net/apidocs/org/joda/time/DateTime.html#withCenturyOfEra(int) http://joda-time.sourceforge.net/apidocs/org/joda/time/DateT... [2] http://msdn.microsoft.com/en-us/library/system.datetime.add(v=vs.110).aspx http://msdn.microsoft.com/en-us/library/system.datetime.add(...
  - shawnz 12y ago
    > The old datetime's method modifies the object in place[-1], if you replace the old with the new it's not going to work anymore. Of course it would be impossible to make the APIs exactly the same, because the two classes have different behaviour. But shouldn't they at least strive to make the APIs as similar as possible?