3 ms·

Curious why you resorted to email diffs around instead of using pull requests on GitHub? It would be cool to see this integrated with the GitHub API so I could

• kelnos 12y ago
  Probably because they aren't using GitHub internally.
• tomheon 12y ago
  Hey there, one of the diffscuss authors here. We were working for a client who used self-hosted svn and had no code review system. As for GitHub API: there's a (beta-ish) import from a pull request into a diffscuss file ("diffscuss github-import" for more), but currently nothing to push it back, which is a tricky problem (since what's displayed on a github pull request is actually a mixture of pull request comments and comments made directly on the commit diffs). But if there's sufficient interest we'll take a look!
  • michaelmior 12y ago
    If the tricky part is that comments are a picture of PR comments and diff comments, it seems like that would be more of a problem for import than export.
    • tomheon 12y ago
      It's tricky to figure out where replies should go, especially if, e.g., there's multiple comments from different sources on the same line. There's also the whole "what if there are comments from multiple authors to write back" problem, since you're presumably only going to have access to the API on behalf of one user. I came away from the time I spent looking at this thinking that you'd probably be better off implementing a separate mode that talked more or less synchronously to GH as you replied etc., rather than working on an import / export cycle. But there might be a better way.