3 ms·
You have to be careful about who you hire. If you do that well, then opinions, code reviews, one shared repository, and so on, work great. If you hire a bunch
by jrockway 12y ago
You have to be careful about who you hire. If you do that well, then opinions, code reviews, one shared repository, and so on, work great. If you hire a bunch of assholes, then they won't work.
I do about 20 code reviews a week; there is never bullying and they are only rarely rubber stamped.
(My favorite code review of my own code this week was where I updated a counter to use atomic.AddInt64 instead of sync.Mutex. But where I was reading the counter, I just read the integer value directly instead of using atomic.LoadInt64. 30 seconds of the reviewers time, and we avoided a potentially difficult-to-track-down bug. No pissing match, no bullying. Just better programs.)
- watwut 12y agoAny company over 30 people will have at least one borderline asshole and one asshole is enough to poison the code review if managed wrong.
- kabouseng 12y ago20 code reviews a week? How many lines of code for each review?
- jrockway 12y agoI looked in more detail and if I average it out over 2.5 years and only include actual code I care about (not importing OSS packages, which I also review), it's more like one a day. I was too lazy to calculate a histogram, but let's go with ~100 lines a day.
- kabouseng 12y agoThanks for the reply.