6 ms·
How do you deal with version-control noise when updating committed assets?
by gkop 12y ago
How do you deal with version-control noise when updating committed assets?
- michaelmior 12y agoJust have a separate commit for these. Not really much different from having a commit which updates bower.json or a Gemfile.
- gkop 12y ago$ bower install angular > /dev/null $ find bower_components/angular/* | xargs wc -l 18 bower_components/angular/angular-csp.css 21463 bower_components/angular/angular.js 210 bower_components/angular/angular.min.js 141 bower_components/angular/angular.min.js.gzip 8 bower_components/angular/angular.min.js.map 7 bower_components/angular/bower.json 48 bower_components/angular/README.md 21895 total That's 21893 more lines in this diff than the equivalent when using rails-assets.
- michaelmior 12y agoSure, if you read through the entire diff it's a lot noisier, but it's still one commit.
- Smudge 12y agoYou claim that it's important to guarantee, with 100% certainty, that the version of a library you're getting in production is the one you expect. But then you say it's not necessary to read through the entire diff if you check that library into source control. What if someone were to make a commit called "Updating jQuery to 2.1" but injected malicious code? Wouldn't that require another way of making sure your vendored files are from a trusted source? Would you still need to check them into source control?
- michaelmior 12y agoI don't recall making that claim.
- Smudge 12y agoYou're right -- my mistake. I mistook your comment for someone else's.