6 ms·
Pierre Joye from Microsoft started a big refactor in the open (make string length size_t everywhere) meanwhile Dmitry Stogov of Zend worked in total secret on a
by chx 12y ago
Pierre Joye from Microsoft started a big refactor in the open (make string length size_t everywhere) meanwhile Dmitry Stogov of Zend worked in total secret on an even bigger refactor which is phpng, completely ignoring the size_t work (also known as 64 bit). A feud in PHP Internals followed not the first heated debate there... that mailing list is very useful as a textbook example of how not to run an open source community. At the end, Pierre have decided it's better to cooperate and now http://news.php.net/php.internals/74352 http://news.php.net/php.internals/74352 there's a vote that seems to pass and so on top of phpng size_t is also coming.
- Yver 12y agoMost disheartening is the way Zeev Suraski pleaded for votes against the size_t/int64 patch in a mail[1] titled "A call for help (urgent)" because, I quote, it "negates months of hard work". That was only a few days after Zend's secret project had been uncovered. The size_t/int64 refactor has been going through several iterations and RFCs since 2013. [1]: http://news.php.net/php.internals/74268 http://news.php.net/php.internals/74268
- kachnuv_ocasek 12y agoWhy? Months of hard work can surely negate months of other hard work.
- danudey 12y agoSure, but it seems pretty irrational to suddenly say 'Hey guys, we've been working on this code without telling anyone, so this community project that people have been working on for months should be abandoned'. They could have been integrating the changes in their code as they went, and then launched with 'Hey, we have this cool new project, including the optimization work that people have been doing'. Instead, they kept their work secret, knowing that their work was incompatible with another large refactor that people were contributing to, and then said 'hey, abandon all the work you were doing because who cares'.
- CHY872 12y agoI think what shocked me the most about that debate was how much the phpng developers tried to undermine Pierre Joye, by even contradicting their own goals. In particular, their primary advertised concern was on the 4% increase in memory usage - but the whole purpose of phpng seems to be to make PHP more compatible with JIT compilation later on - and that seems to almost universally requires large amounts of memory to work really well.
- girvo 12y agoI'm one of those weird developers who loves PHP despite it's warts, and pushes the poor language to it's limit. I love the stuff that's happening in the community (PHP-FIG, the PSR standards, Composer/Packagist, and the like). The thing is, that is all being achieved despite how badly the internals is run. Seriously, I tried to get involved and was turned off entirely by how it's run as an "old boys" clique where new developers and changes are considered enemies. It's really sad, and I think PHP could become a much nicer language overall if that changed. Some people who are far smarted than myself have the same opinion too, so it's not just me...
- danudey 12y agoA lot of people I know who work with PHP on a daily basis agree that PHP is making significant progress despite the PHP internals culture, and not because of it.
- nikic 12y agoI feel like you're giving a very one-sided representation of the issue. There were some very real concerns about the memory usage of the proposed modifications to phpng (you can see http://news.php.net/php.internals/74284 http://news.php.net/php.internals/74284 for an analysis) - what should have happened is that we just went over those changes and decided which parts are feasible and which are not. This happened eventually and now there's a full consensus on how this change is supposed to be implemented (64bit on LLP64, size_t string lengths, uint32_t array lengths). However before that happened the whole discussion was basically a pissing context between Pierre and Zeev. Pierre was most certainly not the one who got us back to cooperating.
- CHY872 12y agoI don't think so. Pierre worked on this in the open, whilst the phpng team did their work in secret. That makes it at least inconsiderate of them that Pierre was not told that the changes might break optimisations in phpng - there should have been a clear communication from them that major changes were coming to php which would affect the utility of his work, and that he should consider holding off. Then, the arguments made in the discussions were basically besides the point. Overall memory usage is not really important on modern hardware, since memory is cheap. The real concerns are time performance - if the performance is degraded, it would be a valid reason to reject some of the changes. The vast majority of criticisms were just along the lines of 'but why do we even need 4GB+ strings' - I can see exactly why Pierre would get frustrated at having to parrot the same line. Performance in current php was clearly fine, and performance in phpng was only ever mentioned in completely vague terms - the most empirical it got was 'i guess 20-30% worse' which isn't really a trustworthy figure by any means. The burden there was up to the phpng team to recognise that there were changes in the standard php pipeline that would potentially invalidate some optimisations. Coming in at a late stage and saying that it would ruin everything, having made no effort to stop someone wasting much time, was at least inconsiderate and probably rude also. Then attempting to effectively filibuster the situation by repeatedly firing irrelevant arguments at Pierre, then recruiting randoms to try and vote against it as some kind of 'we are being undermined' campaign, then trying to change the voting rules, it all just smacked of a very amateurish and/or rude community. Yes, they were mostly by the same people, but at some point someone could have very easily come out and pointed out (for example) the inherent fallacy in the 4GB+ argument, or the fact that the phpng developers should have informed Pierre earlier that their new optimisations might conflict. It seemed like a number were happy letting some fight their preferred argument with the wrong reasons. The arguments of 'wasted data' aren't convincing - the arguments of 'wasted data causes poor performance' would be convincing were there any data whatsoever to back it up, and if those who argued actually worked from that standpoint. My problem was (as someone who read the mailing list) was simply that the very real concerns were brushed under the carpet, and that the situation was allowed to develop in the first place.