4 ms·
If ag knows it can't search the whole file, it should at least give a warning. Or why not use search_stream? Silently skipping parts of it seems like the worst
by tveita 12y ago
If ag knows it can't search the whole file, it should at least give a warning. Or why not use search_stream?
Silently skipping parts of it seems like the worst thing to do.
- ggreer 12y agoGood point about the warning. I'll add that. With regards to search_stream() in search.c... all I can say is that I'm sorry: https://github.com/ggreer/the_silver_searcher/blob/master/src/search.c#L163 https://github.com/ggreer/the_silver_searcher/blob/master/sr... I built ag for myself; both as a tool and to improve my skills profiling, benchmarking, and optimizing. Had I known how popular it would become, I would have definitely held myself to a higher standard, or any standard. Most importantly, I'd have written tests. These days, I'm busy with a startup so progress on those fronts has been slow.
- x0x0 12y agoit's an awesome tool I use dozens of times a day, so thank you
- masterj 12y agoFor me ag has been magical. It does exactly what I want 99% of the time and is just blazingly fast. So.. thanks :)
- mpercy 12y agoag is incredible, especially paired with Ack.vim and a mapping. I use <leader>as to search for the current word under the cursor. The results are instantaneous. With ag and YouCompleteMe, I never fall back to cscope/ctags in C++ projects anymore. One thing though, it skips certain source files seemingly arbitrarily without the -t param and I haven't figured out why... Doesn't seem related to any .gitignore entries that I have been able to identify.