5 ms·

So rare that I'm not sure why this got any attention. There are more interesting bugs to look at, which i do see in the wild a lot (e.g. redirect_to params[:ret

by homakov 12y ago

So rare that I'm not sure why this got any attention. There are more interesting bugs to look at, which i do see in the wild a lot (e.g. redirect_to params[:return_url])

epochwolf 12y ago
If anyone is interested, I've got a set of helper functions for redirects. https://github.com/epochwolf/litsocial/blob/master/app/lib/controllers/redirect_protection.rb https://github.com/epochwolf/litsocial/blob/master/app/lib/c...
- homakov 12y ago
  Redirects are hard to get right. Bypass 1 - //host.com. Even if you will use URI library Bypass 2 - ///host.com
  - epochwolf 12y ago
    Good point, I'll need to modify the redirect to disallow multiple slashes at the beginning. That should be something like /\A(http(s?):\/\/#{request.host_with_port}|\/\Z|\/[^\/])/
    - homakov 12y ago
      /\host.com