4 ms·
Thanks a lot for code review, I'm reading, but you have made many unjustified claims and based on results I would say your conclusion is not valid. You have al
by shakiba 12y ago
Thanks a lot for code review, I'm reading, but you have made many unjustified claims and based on results I would say your conclusion is not valid.
You have also made personal attack ("your dishonesty"), probably because of your own competing library (jsil.org).
- kevingadd 12y agoFeel free to ignore the unsolicited advice on how to improve your software from someone who's been working on games and game engines for 10 years. I ran your sample under a profiler and saw obvious problems with CPU and memory performance, and there are obvious problems with GPU efficiency based on your rendering model. This is not subjective; profiling is objective. P.S. JSIL doesn't compete with your library, it's a cross-compiler. Are you angry because I gave a specific example of how I used one of the optimizations I suggested, or just because I'm pointing out that your website is dishonest? EDIT: I shouldn't have to point this out either, but saying 'this text you wrote is dishonest' is not a personal attack. It's an objective criticism of your writing. Saying 'it's dishonest to call this library fast because x' is also not a personal attack, it is an objective criticism of your code. If I called you a liar or a dishonest person, that would be a personal attack. I have not done that. I could certainly make that claim based on your argumentative style in this thread, but I shall not.
- shakiba 12y agoActually I love your feedbacks, but putting your quick conclusion on top and putting personal attack on bottom is strange. Your exact phrase is "your dishonestly", you could have described it as "inaccurate description" instead.
- kevingadd 12y ago'dishonesty' describes a dishonest or deceitful act, and I was referring to the act of writing 'fast' on your website. I don't believe this was an inappropriate use of the term. I apologize if for whatever reason you believed that to be a personal attack - I did not intend to hurt you and if I did, I am sorry. But I will not retract what I wrote, because I believe it is accurate.
- shakiba 12y agoNo worries. Peace! I'm almost done answering your first comment.