3 ms·

>Yeah, off of an open source repository on github that the community can inspect. That doesn't make it better. What if your internet connection craps out while

by vhost- 12y ago

>Yeah, off of an open source repository on github that the community can inspect. That doesn't make it better. What if your internet connection craps out while it's downloading the line "rm -rf /usr/local/bin/old-binary" and it happens to stop at "rm -rf /usr"? Oops.

bennyg 12y ago
Is it on a stream-and-run method of executing tasks? Surely it looks for an end-of-line or end-of-command terminator like "\n"
- vhost- 12y ago
  Curl will still pipe partials: http://blog.existentialize.com/dont-pipe-to-your-shell.html http://blog.existentialize.com/dont-pipe-to-your-shell.html
  - bennyg 12y ago
    That's so sketch and dangerous.
plorkyeran 12y ago
This is trivially fixable by wrapping the body of the script in a function which is invoked at the end. Homebrew's install script doesn't do this, but it's written in Ruby and all of the side-effecting statements are within a single block, so the worst that could happen is it could fail to print the message telling you that it's installed at the end.