3 ms·

Unless the guy was hyper-vigilant about reverting her code (as in, within a few seconds of her pushing her own commit), wouldn't that be a ridiculously noticeab

by kemayo 13y ago

Unless the guy was hyper-vigilant about reverting her code (as in, within a few seconds of her pushing her own commit), wouldn't that be a ridiculously noticeable way to do it? Other people would have pulled, and would find themselves inconsistent with the origin repo when they next went to push... Not saying it's impossible, but it seems like it'd have generated some documentation if it happened, probably in the form of people sending out "WTF? Who's pushing history-changes???" emails. Edited to add: Also, the article says they reviewed git push logs, which I imagine would catch this.

pyre 13y ago
> as in, within a few seconds of her pushing her own commit Is it really only possible for a revert to happen 'within a few seconds' to not cause issues? That's a strong statement to make based on little information. It might be true, but the repository in question could also have little traffic, or this could have happened over a weekend. > Also, the article says they reviewed git push logs, which I imagine would catch this. I see. I guess overlooked that (probably just read it as 'commit logs'). In general, I don't understand why they didn't just ask her about the commits in question. If it did happen, she would likely be able to point them in the right direction and at least narrow their search (e.g. 'the revert happened in repository X around these dates'). If she couldn't, then they are no better off, but no worse off either.
- kemayo 13y ago
  > That's a strong statement to make based on little information. That's a fair point. It'd depend a great deal on how github has their repos set up, and I can't remember seeing anyone talk about that.