4 ms·
It's cool they're doing this cleanup, but overly self-righteous commit messages (http://opensslrampage.org/ http://opensslrampage.org/) on patches like http://w
by bla2 12y ago
It's cool they're doing this cleanup, but overly self-righteous commit messages (http://opensslrampage.org/ http://opensslrampage.org/) on patches like http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/crypto/asn1/a_time.c.diff?r1=1.15;r2=1.16 http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/cry... rub me the wrong way (I'm sure comparing a string pointer to '5' / decimal 53 is _exactly_ what the old, ridiculed code meant to do…)
- bla2 12y ago(To their credit, they did fix this bug 2 hours later: http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/crypto/asn1/a_time.c.diff?r1=1.16;r2=1.17 http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/cry... http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/crypto/asn1/a_time.c http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/cry... )
- Gigablah 12y agoWell, fixing legacy code is generally regarded as crap work and developers need to vent. Still, they're lucky that they're not implementing the actual crypto code, otherwise they'll face much worse public beatdowns.
- jevinskie 12y agoThat is pretty bad. I can't see how that wouldn't give a new compiler warning that would tell the dev that they probably shouldn't commit that patch.
- xarball 12y agoYou may need a few compiler flags turned off to compile OpenSSL ;) That said, many opensource projects ignore the vast majority of compilation warnings. Many projects do the same.
- Touche 12y agoThis is why I would never use OpenBSD (but yeah, I use OpenSSH). Can't use an OS for people with this type of attitude.