3 ms·
Speaking as someone who spends a big chunk of his working life auditing others code, having a consistent style makes it a lot easier to spot problems.
by danrik 12y ago
Speaking as someone who spends a big chunk of his working life auditing others code, having a consistent style makes it a lot easier to spot problems.
- jgrahamc 12y agoBut isn't what's happening here a change to the coding style to match the style used by BSD? That might be fun for BSD coders, but is that actually helping improve the OpenSSL code?
- clarry 12y agoIt might not help upstream OpenSSL, unless they keep an eye out for the bug fixes. Consider OpenBSD the upstream for this new fork.
- mfwoods 12y agoI don't think they intend to contribute back to the original OpenSSL code base, but see this as a OpenBSD only fork.
- feld 12y agoman style http://www.openbsd.org/cgi-bin/man.cgi?query=style&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html http://www.openbsd.org/cgi-bin/man.cgi?query=style&apropos=0...
- gkya 12y agoWell, that'd be useless to move from tabs to spaces or from n spaces to m spaces in this context, but as far as I've observed, OpenSSL codebase uses the unconventional Whitesmiths style [1][2][3], which might be a burden on the developers to navigate. [1] http://en.wikipedia.org/wiki/Indent_style#Whitesmiths_style http://en.wikipedia.org/wiki/Indent_style#Whitesmiths_style [2] http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/crypto/sha/sha.c?rev=1.1.1.2;content-type=text%2Fplain http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/cry... [3] http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/crypto/dsa/dsa_depr.c?rev=1.1.1.1;content-type=text%2Fplain http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/cry... edit: formatting