4 ms·
Maybe someone can help me, it is said It has a time-based nonce, which provides built-in resistance against replay attacks, I'm looking where in the code the ti
by doe88 13y ago
Maybe someone can help me, it is said It has a time-based nonce, which provides built-in resistance against replay attacks, I'm looking where in the code the time-based nonce is verified/handled on the receiver, but I can't find it.
What I see: when a packet is decrypted the time-based nonce is unpacked here [1] and this function seems to be called from here [2] but nowhere I can't find where this nonce is verified not to be too old, what am I missing?
[1] https://github.com/neilalexander/sigmavpn/blob/c7f60ecfdb22badae819fa965bc657286983c391/proto/proto_nacltai.c#L247 https://github.com/neilalexander/sigmavpn/blob/c7f60ecfdb22b...
[2] https://github.com/neilalexander/sigmavpn/blob/c7f60ecfdb22badae819fa965bc657286983c391/main.c#L423 https://github.com/neilalexander/sigmavpn/blob/c7f60ecfdb22b...
- nodata 13y agohttps://news.ycombinator.com/item?id=7599941 https://news.ycombinator.com/item?id=7599941
- onedognight 13y agoThis is a real bug. You can see that in the code[0] this was based on that they do at least check the nonce/timestamp. [0] https://github.com/UCIS/QuickTun/blob/master/src/proto.nacltai.c#L99-L102 https://github.com/UCIS/QuickTun/blob/master/src/proto.naclt...
- neilalexander 13y agoYou are correct about this, and I have updated the code to include the replay protection. (Apparently I became sidetracked before!) I am not sure if the method that is used in the quicktun source to prevent replay is ideal, and I am fairly certain that I need to revise the method used to generate the nonce too.