4 ms·

Shouldn't code review be higher than unit tests?

• arjunnarayan 13y ago
  Ideally your unit tests are run on each build, so you hit the tests locally, before you push your changes in for a code review.
• eldude 13y ago
  Most definitely not. Human processes are always inferior to software enforcement. Code reviews are heavily dependent upon leadership, training, and quality control factors likes comprehensibility[1], mood, problem domain familiarity, etc... [1] Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. -- https://twitter.com/girayozil/status/306836785739210752 https://twitter.com/girayozil/status/306836785739210752
  • Too 13y ago
    Unit tests are also made by human processes :) The advantage is if they were made good that time they will give you nice regression coverage for free in the future.
  • Iftheshoefits 13y ago
    Unit tests aren't intrinsic or automatic. They're extra pieces of code that have to be written, debugged and maintained by human beings. They ought to be considered as little more than extremely limited, narrowly-scoped sanity checks; not definitive pass/fail gates for the code they're exercising.