4 ms·
Opening a PR to discuss a new feature before it is built.
by nahname 12y ago
Opening a PR to discuss a new feature before it is built.
- bnferguson 12y agoI use this constantly. Building a PR up with lot of people watching and involved is pretty amazing. Certainly don't need to all the time, but when working on something sensitive or still ambiguous it's invaluable. So many of my PRs have 50-70 comments by the time they go in. Amazing review at every step of the way.
- roryokane 12y agoYou can also do that by just creating an Issue, and then converting it to a Pull Request later with `hub pull-request -i <existing-issue-num>`, when you actually have some code to commit. That uses the software Hub, mentioned in the cheat sheet. Or instead of installing Hub, you can convert the Issue using one of the other methods listed in http://stackoverflow.com/q/4528869/578288 http://stackoverflow.com/q/4528869/578288.
- reledi 12y agoI don't recommend converting issues to Pull Requests. See the discussion here which goes into details: https://github.com/github/hub/commit/4f70dd126f46dec14fc341c97c18efae417743c7 https://github.com/github/hub/commit/4f70dd126f46dec14fc341c...
- reledi 12y agoFantastic suggestion! I always disliked opening a PR after my first code change. Will definitely start using this :)