5 ms·
Disagree wholly. I don't think that a commit should be littered with commented out code, but there clearly are positive reasons to have some. Besides, if the
by ronaldx 13y ago
Disagree wholly.
I don't think that a commit should be littered with commented out code, but there clearly are positive reasons to have some.
Besides, if the comment is not there, how can you be expected to know that there is old but still relevant code in the repo?
- jon2512chua 13y agoOut of curiosity: What are the positive reasons in having commented out code?
- hcarvalhoalves 13y agoSometimes just the presence of code triggers a bug because of dynamic dispatching / whatever, and a hotfix is necessary. You could remove, but then later programmers wouldn't have context to fix the bug properly. # TODO: Figure out why do_foo is triggering a bug # http://my-company.org/issues/42 # def do_foo(self): # ...
- sjy 13y agoIf the code is commented out, how can it be relevant?
- clarry 13y ago"We cannot enable this yet, because foo isn't implemented yet, or because bar doesn't work correctly."