2 ms·
Every good open source project I've seen will happily accept and merge refactoring pulls, as long as the refactoring: -Actually makes the code cleaner. -Reduc
by meowface 13y ago
Every good open source project I've seen will happily accept and merge refactoring pulls, as long as the refactoring:
-Actually makes the code cleaner.
-Reduces redundancies.
-Above all, actually results in there being less code than there was before.
If you can achieve clean code + negative lines of code after a refactor, with identical functionality, they'd be fools to not merge it.
It's possible the refactors you submitted didn't meet these requirements. Or the project owners simply were too possessive of the code they wrote with their own fingers.
- Xdes 13y agoThe project lead explained that he didn't accept unsolicited commits. My code ended up getting merged with some other guys refactored code which eventually made it into the code base.
- pc86 13y ago> The project lead explained that he didn't accept unsolicited commits Isn't that sort of contrary to OSS?
- dragonwriter 13y ago> Isn't that sort of contrary to OSS? No, OSS is a licensing model not a development model. With OSS, if the existing project has a dev model you don't like, you can always fork it and start a project with a dev model you do; with proprietary software (even if the source is available), if you don't like the development model (among other things you might not like) you're, well, forked.