4 ms·
Just a note to the author if they are reading: you might want to remove that OSC code for inline HTML. There are reasons dynamic codes like those don't exist.
by chjj 13y ago
Just a note to the author if they are reading: you might want to remove that OSC code for inline HTML.
There are reasons dynamic codes like those don't exist. Good reasons. (In my own naivete, I once thought an OSC code to access scrollback would be a good idea. You can imagine how insecure that was). It's not a good idea to run any programs in this terminal until that OSC code is either removed or the HTML is somehow sanitized.
- panzi 13y agoWhat's OSC? Open Sound Control? Open Source Code? I'm not familiar with that acronym.
- chronomex 13y agoIt's a type of terminal escape code, designed to interact with the terminal emulator's environment. https://en.wikipedia.org/wiki/ANSI_escape_code#Non-CSI_codes https://en.wikipedia.org/wiki/ANSI_escape_code#Non-CSI_codes
- jahewson 13y ago"Operating System Command"
- bentcorner 13y agoI think the concern is around this bit: https://github.com/paradoxxxzero/butterfly/blob/4dc55630a3ab3d1162f5967e3f3f9ec95dc7f100/butterfly/static/coffees/term.coffee#L775 https://github.com/paradoxxxzero/butterfly/blob/4dc55630a3ab... Is the problem that there's a potential for a terminal app to inject non-sanitized HTML into a terminal that is using butterfly?
- cfontes 13y agoWould be awesome if you could make a pull or open an issue. https://github.com/paradoxxxzero/butterfly https://github.com/paradoxxxzero/butterfly Maybe the author ( as I ) is not sure about this or knows how to fix it. Cheers
- albertzeyer 13y agoThat OSC code might be the key to make this project really interesting and powerful. But you are right, to make this safe, some sanitization or other sandbox would be needed. This could be hard/impossible if there is JavaScript involved in the inline HTML.