3 ms·
> I think so, yes. The performance difference is already negligible with Om, so I didn't see a real need to optimize it any further. Sorry, I was unclear: my c
by haberman 13y ago
> I think so, yes. The performance difference is already negligible with Om, so I didn't see a real need to optimize it any further.
Sorry, I was unclear: my comments were about the (slow) first benchmark you posted that is using React but not using your library. I think it would be orders of magnitude faster with requestAnimationFrame.
- drfloob 13y agoEDIT: not true. see below. ---------------------------- Good call! Benchmark 1 is about 33x faster in my browser (with the setTimeout fallback being used, I think).~ http://drfloob.github.io/todomvc/labs/architecture-examples/react-raf/ http://drfloob.github.io/todomvc/labs/architecture-examples/... This is the same React TodoMVC example with a different `react-with-addons.js`, built using React v0.9.0 and https://github.com/petehunt/react-raf-batching https://github.com/petehunt/react-raf-batching.
- swannodette 13y agoThe timings you are presenting in the UI are not accurate. But you are correct that this approach results in timings that are almost identical to Om. Use the Chrome Dev Tools profiler flamegraph if you want to confirm what I'm saying.
- drfloob 13y agoAh, right. Benchmark 1 is actually ~350ms on my machine. Thanks for the lesson in profiling asynchronous code. I revisited the React+_tree benchmark claims, too, and I think they are still spot on. If you're interested at all, I'd appreciate you taking the time to check my work there.
- swannodette 13y agoI took a look but it's hard to judge since you are using React 0.8.0 and Om is now on React 0.9.0.