4 ms·
I think what this really shows is that Apple has no unit tests to cover the security of their products. And that is pretty scary.
by outside1234 13y ago
I think what this really shows is that Apple has no unit tests to cover the security of their products. And that is pretty scary.
- rdl 13y agoI don't think you necessarily need unit tests to catch this; code review would work (even I probably would have caught this if I'd actually read it; "fucking gotos" would have drawn my attention to begin with, and if it was a single line commit, even more so.) The problem is Apple (intentionally) understaffs and overworks, so I doubt they have the spare people to look at most commits.
- sneak 13y agoIf only they had the money to devote to quality engineers to ensure good processes surrounding their most critical, security-sensitive code. You can't really blame them for doing the best they can with limited resources. Startup life is hard.