6 ms·
For a major patch that may affect a project for a long time going forward, I can understand the maintainer being strict about what gets applied, and wanting to
by donutdan4114 13y ago
For a major patch that may affect a project for a long time going forward, I can understand the maintainer being strict about what gets applied, and wanting to have more code quality control.
This patch is miniscule. He should have applied it and moved on.
- iurisilvio 13y agoAgreed. I was expecting a large piece of code to justify a second guess about merging it right now (or just declining it with a good reason). It hurts OSS, even if it is a maintainer's right.
- pekk 13y agoAnonymous cowards launching personal attacks years down the line on account of trivial decisions like not merging a particular patch doesn't hurt OSS? Should we stand by and encourage people to blast Alan Cox for every patch that wasn't included in Linux that someone wanted in there? Does that help OSS?
- iurisilvio 13y agoYes, it was a trivial decision and looks like that decision was not taken, so people expected that to happen sometime: "Well, I've said multiple times that I'll be working on this during the PyCon sprints". More than that, the closing message: 'Closing, rejected, due to use of "approval" as spam.' Yes, it is up to the maintainer to do that. How he do that matters.