4 ms·
Looks great. One thing that I find not so good is: There are no tests. It would be hard to convince anyone to contribute without some unit tests.
by humanfromearth 13y ago
Looks great. One thing that I find not so good is: There are no tests.
It would be hard to convince anyone to contribute without some unit tests.
- mattwestcott 13y agoThere are some https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailsearch/tests.py https://github.com/torchbox/wagtail/blob/master/wagtail/wagt... - but not enough, we know. We're on it!
- tomd 13y agoSee below - there are tests, see https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailsearch/tests.py https://github.com/torchbox/wagtail/blob/master/wagtail/wagt... and https://github.com/torchbox/wagtail/commit/a77977a31cdfcdf955586ee796fa0ec406ae4b4a https://github.com/torchbox/wagtail/commit/a77977a31cdfcdf95... but we need more, and to make it more obvious how to run them. You're right that we have to do more to attract contributors. In the meantime we're offering t-shirts for pull requests... https://twitter.com/WagtailCMS/status/432166799464210432/ https://twitter.com/WagtailCMS/status/432166799464210432/