3 ms·
I'm really glad you replied. I'm not trying to be a dick, but I'm comparing it other frameworks that I'm familiar with. I disagree quite strongly with not tryi
by ihsw 13y ago
I'm really glad you replied. I'm not trying to be a dick, but I'm comparing it other frameworks that I'm familiar with.
I disagree quite strongly with not trying to adhere to composer packaging guidelines, since it's common to many PHP developers (especially those on HN) that using it shouldn't be an issue.
Also, tying into composer would help you as a developer as well -- there is a very large body of packages available that are quite stable and reliable.
A lot of what I went over is mostly semantics/preference, however those are important to me. No shame, no guilt -- just constructive criticism.
- superice 13y agoSure, no hurt feelings ;) I hope I didn't sound like I thought of you like a dick in my previous comment, that was not my intention. I'll look at composer, that certainly looks promising. (But quite hard too...) I'm always in for some constructive criticism, you do have valid points. But the thing is this framework isn't designed to be professional, it's designed for a simple copy-paste-program workflow. (Or in this case: 'git clone'-program). I never intended to write a great framework that can be used in any situation and is exactly following the standards to the last indentation, so that's not where I'll put my effort into. Big mistakes, however, like the Database::safeQuery(), are worth fixing. At first I didn't have events too, until someone alerted my that might come in handy, so I added it, and I am sure I'm going to use that one a lot.