5 ms·

* I don't like composer. This isn't some big framework everyone should use because it is good practice, or because it is such a great thing. It's easy. The way

* I don't like composer. This isn't some big framework everyone should use because it is good practice, or because it is such a great thing. It's easy. The way I like it. * define() is a great way for < 4 variables. Seriously, whats the point of creating a whole config class when I could just execute 4 times a define(); Heck, maybe I should put them in the same file! * Jep, MySQL only. As I said, this isn't some cool framework which can be used everywhere. It's simple. Very simple. * Whoa, those singletons aren't needed. I'm not quite an expert on unit testing, but I am sure unit testing won't be much harder this way. * As of the rudimentary routing, you are right. I probably should support custom routes in some way. * The templating system blows. But again, one doesn't need more when setting up a simple project. * Database::safeQuery() is indeed not great. I'll make it an issue. Someone pointed it out earlier to me and I forgot to fix it the right way. It used to be even more vulnerable. Shame on me. It was an interesting learning experience, and I don't think I'm done yet. But I thought maybe some people think it's interesting, and it turns out some do. (See the number of upvotes/stars/comments) PSR-1 and PSR-2 is not my style. Indentation sucks, I'll change that, but I will not change everything into PSR compliant code. Again: simplicity. I am pretty constant in my code style, so that can't be an issue.

ihsw 13y ago
I'm really glad you replied. I'm not trying to be a dick, but I'm comparing it other frameworks that I'm familiar with. I disagree quite strongly with not trying to adhere to composer packaging guidelines, since it's common to many PHP developers (especially those on HN) that using it shouldn't be an issue. Also, tying into composer would help you as a developer as well -- there is a very large body of packages available that are quite stable and reliable. A lot of what I went over is mostly semantics/preference, however those are important to me. No shame, no guilt -- just constructive criticism.
- superice 13y ago
  Sure, no hurt feelings ;) I hope I didn't sound like I thought of you like a dick in my previous comment, that was not my intention. I'll look at composer, that certainly looks promising. (But quite hard too...) I'm always in for some constructive criticism, you do have valid points. But the thing is this framework isn't designed to be professional, it's designed for a simple copy-paste-program workflow. (Or in this case: 'git clone'-program). I never intended to write a great framework that can be used in any situation and is exactly following the standards to the last indentation, so that's not where I'll put my effort into. Big mistakes, however, like the Database::safeQuery(), are worth fixing. At first I didn't have events too, until someone alerted my that might come in handy, so I added it, and I am sure I'm going to use that one a lot.

ihsw 13y ago

I'm really glad you replied. I'm not trying to be a dick, but I'm comparing it other frameworks that I'm familiar with. I disagree quite strongly with not trying to adhere to composer packaging guidelines, since it's common to many PHP developers (especially those on HN) that using it shouldn't be an issue. Also, tying into composer would help you as a developer as well -- there is a very large body of packages available that are quite stable and reliable. A lot of what I went over is mostly semantics/preference, however those are important to me. No shame, no guilt -- just constructive criticism.

superice 13y ago
Sure, no hurt feelings ;) I hope I didn't sound like I thought of you like a dick in my previous comment, that was not my intention. I'll look at composer, that certainly looks promising. (But quite hard too...) I'm always in for some constructive criticism, you do have valid points. But the thing is this framework isn't designed to be professional, it's designed for a simple copy-paste-program workflow. (Or in this case: 'git clone'-program). I never intended to write a great framework that can be used in any situation and is exactly following the standards to the last indentation, so that's not where I'll put my effort into. Big mistakes, however, like the Database::safeQuery(), are worth fixing. At first I didn't have events too, until someone alerted my that might come in handy, so I added it, and I am sure I'm going to use that one a lot.