4 ms·
Please don't mix tab and spaces :( https://github.com/goldenice/Kamele-Framework/blob/master/system/basecontroller.php https://github.com/goldenice/Kamele-Frame
by masom 13y ago
Please don't mix tab and spaces :( https://github.com/goldenice/Kamele-Framework/blob/master/system/basecontroller.php https://github.com/goldenice/Kamele-Framework/blob/master/sy...
Using proper namespaces would be great, the `System` namespace will probably collide with other projects. `Kamele\System` would be much better.
Using PDO would be much better than the `mysqli` functions.
Where are the unit tests?
- BESebastian 13y agoMuch of the complaints I had, also the baffling license choice when it could just as easily be released under the MIT license or whatever others there are out there.
- masom 13y agoIndeed. I don't quite understand the reasoning behind the license.
- superice 13y agoAh I see, the MIT license does cover pretty much everything I needed. After looking for half an hour for a decent license I thought it would just be easier to write my own. MIT license will be included in the next push. What I am thinking of is pretty much the Do What the Fuck you Want to Public License, but only keeping that license itself. It's hard to find that...